Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Confirmation from different browser, Missing needed parameter email #830

Closed
a1Gupta opened this issue Jan 28, 2016 · 6 comments
Closed

Comments

@a1Gupta
Copy link

a1Gupta commented Jan 28, 2016

Python Social Auth is undoubtedly one of the best plugin for Social Authentication and I expect a lot of people are using it in production. But I see a major bug here in email Authentication while adding a new email during new account creation.

The case can be replicated as follows -

  1. Create a new user account using email. An Email confirmation link will be sent to user.
  2. Confirm the link from other browser
  3. This will give Missing needed parameter email error.

This is because there's dependency on the session for the mail validation partial, which is not an expected behavior. User should be able to confirm his email from any browser.

This issue was raised here #577. @omab told that -

I see the problem now, and even if I think that this could be solved with a re-write of the email validation pipeline, this affects all the pipeline functions that use the partial mechanism, so, I'm already working on a restructure of the pipeline serialization functionality that will improve this behavior. Basically the pipeline data will be dumped to a DB table and a hash code will be used to identify the processes which can be stopped and continue later, removing the dependency of the session.

But I see no updates on this after that, even after the new version is out now. @omab can you please update regarding this.

  1. When are you going to fix this issue ?

  2. If you are not working on this, what should be the workaround to fix this issue.

    I don't want to play with this pipeline mechanism as any change can lead to serious issues in authentication. Currently I am using this monkey patch which is not perfect.

@omab it seems like a serious issue as many users will not be able to sign up leading to a weird user experience. Everyone who is using psa in production will be facing this issue. Please give urgent attention on this.

@kemar
Copy link

kemar commented Feb 9, 2016

👍

1 similar comment
@hartym
Copy link

hartym commented Feb 9, 2016

👍

@franlu
Copy link

franlu commented Mar 1, 2016

Please give urgent attention on this.
👍

@danielskun
Copy link

👍

1 similar comment
@tomislater
Copy link

👍

@omab
Copy link
Owner

omab commented Dec 27, 2016

I've created this issue python-social-auth/social-core#7 to track the work needed to support this scenario.

@omab omab closed this as completed Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants