Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to announce a decision #10

Open
omallassi opened this issue Dec 6, 2019 · 3 comments
Open

Be able to announce a decision #10

omallassi opened this issue Dec 6, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@omallassi
Copy link
Owner

See If / who we could announce a decision.

For instance,

  • it could be a specific command e.g. adr accounce --decision ....
  • it could be done when a decision status is updated
  • it could be done through multiple medias (Slack, Microsoft Teams, emails etc...) which may drive security (authentication at least) questions.
@omallassi omallassi added the enhancement New feature or request label Jan 15, 2020
@rustysys-dev
Copy link
Contributor

@omallassi I think this is fantastic!

It would be great to see Mattermost or Zulip

A few things to consider:

  • Suppression of the announcement when an decision is created adr lf new ... as that would create a notification without substance.
  • Send a copy of the file with the announcement

@omallassi
Copy link
Owner Author

yes.
maybe we can think about having "kind of plugins" to support different "channels". no idea how we can do this in rust but a go opportunity to learn :)

@rustysys-dev
Copy link
Contributor

rustysys-dev commented Jun 3, 2020

I think it would be interesting to develop a plugin system.

Choosing the plugin could be as easy as adr announce --decision <id||name> --plugin <plugin_name>

id being an idea from #36 as decision names could be long and typing an id preferable.

Additionally, the default plugin for the user could be defined in the config as adr_default_announce_plugIn

As far as implementation goes, I'm not an expert in rust by any means so correct me if I am wrong but we could create a trait (announce_plugin or something similar) and implement it for each of the plugin structs. This would allow for a unified interface for all announce_plugins...what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants