Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer to peer code review #6

Open
yersel500 opened this issue Mar 1, 2022 · 0 comments
Open

Peer to peer code review #6

yersel500 opened this issue Mar 1, 2022 · 0 comments

Comments

@yersel500
Copy link

Congratulations, your project meets all the requirements and your style of code is understandable. Only a few suggestions that can improve your project:

  • When I click on the edit icon, it automatically autoselects all the tasks, could be better if only the cursor appears at the end to start the editing.
    See image here
  • As you created a class, you can take advantage of it using methods. It could help you to avoid defining many functions and your code will you more organized.
  • About the use of modules, you can try moving functions to a new module. In this way, your index.js only maintains the event listener.
  • You can delete a task without the need to mark it as completed. Could be better if only the completed tasks can be deleted.

Happy coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant