-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unhandled Info.plist
when importing with SPM
#12
Comments
Thanks @sbertix, both are valid options, I'm leaning a little bit toward ignoring the file in Package.swift, what do you think? |
It definitely makes sense in the short run, but I feel like it's not extremely intuitive to have the I would argue that even having the actual project file for the test app at root level might give the wrong impression on the scopes of the library itself ("is this a library? Is this an app?") and it would probably make more sense hidden inside the I understand this is, however, although an easy "fix", far beyond the scopes of the actual issue here π
|
Nice, I actually like the idea of removing the Xcode project from the root directory |
I merged the PR to release a quick patch, feel free to open another PR with the proposed changes above |
Hey @omaralbeik,
amazing job with this library πͺ
I've found an issue when using Drops with the SPM:
Possible fixes would be moving the
Info.plist
out of theSources
folder β as it's only used in the test-wrapper app, or explicitly excluding it fromPackage.swift
target.I'd push a PR but I'm not really sure which approach you'd rather follow π
The text was updated successfully, but these errors were encountered: