Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled Info.plist when importing with SPM #12

Closed
sbertix opened this issue May 11, 2021 · 4 comments
Closed

Unhandled Info.plist when importing with SPM #12

sbertix opened this issue May 11, 2021 · 4 comments

Comments

@sbertix
Copy link
Contributor

sbertix commented May 11, 2021

Hey @omaralbeik,

amazing job with this library πŸ’ͺ

I've found an issue when using Drops with the SPM:

Screen Shot 2021-05-11 at 19 45 58

Possible fixes would be moving the Info.plist out of the Sources folder – as it's only used in the test-wrapper app, or explicitly excluding it from Package.swift target.
I'd push a PR but I'm not really sure which approach you'd rather follow πŸ˜…

@omaralbeik
Copy link
Owner

Thanks @sbertix, both are valid options, I'm leaning a little bit toward ignoring the file in Package.swift, what do you think?

@sbertix
Copy link
Contributor Author

sbertix commented May 11, 2021

It definitely makes sense in the short run, but I feel like it's not extremely intuitive to have the Info.plist for the test app with the actual src.
It's confusing, other than adding one step to people maybe wanting to drop the actual folder directly in their project (being a small library) β€” cause such people will always exist hahaha

I would argue that even having the actual project file for the test app at root level might give the wrong impression on the scopes of the library itself ("is this a library? Is this an app?") and it would probably make more sense hidden inside the Tests directory, together with its Info.plist, referencing the Sources directory either through header paths or even as a local SPM dependency.

I understand this is, however, although an easy "fix", far beyond the scopes of the actual issue here πŸ˜…
Sorry hahaha

@omaralbeik
Copy link
Owner

Nice, I actually like the idea of removing the Xcode project from the root directory

@omaralbeik
Copy link
Owner

I merged the PR to release a quick patch, feel free to open another PR with the proposed changes above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants