Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: video length without starting playback #670

Closed
woj-tek opened this issue Aug 4, 2019 · 3 comments
Closed

Request: video length without starting playback #670

woj-tek opened this issue Aug 4, 2019 · 3 comments
Labels
enhancement Improvement of an existing feature

Comments

@woj-tek
Copy link

woj-tek commented Aug 4, 2019

Would it be possible to display video length without starting playback?

@omarroth omarroth added the enhancement Improvement of an existing feature label Aug 5, 2019
@leonklingele
Copy link
Contributor

Simple fix:

diff --git a/assets/css/default.css b/assets/css/default.css
index c527cbc..3644f6c 100644
--- a/assets/css/default.css
+++ b/assets/css/default.css
@@ -328,7 +328,7 @@ input[type="search"]::-webkit-search-cancel-button {
   width: 50px;
 }

-.vjs-control-bar {
+.video-js .vjs-control-bar {
   display: flex;
   flex-direction: row;
 }

This however shows the full control bar even before the video has started playing. This might be undesired for the same reason as #661.

@omarroth would you be willing to accept a patch which adds a new configuration option (don't cover video poster) that combines #661 and the change mentioned above? imo, the option should be unchecked by default.

@omarroth
Copy link
Contributor

omarroth commented Aug 6, 2019

Would it make sense to implement it as a Player style preference with default/Invidious and YouTube?

leonklingele added a commit to leonklingele/invidious that referenced this issue Aug 9, 2019
This currently includes the following styles:

- Invidious, the default
- YouTube, using a centered play button and always visible video control bar

Implements iv-org#670.
Supersedes iv-org#661.
@omarroth
Copy link
Contributor

Added with #680.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants