Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing To Do list: part 1 #7

Merged
merged 2 commits into from Jan 19, 2022
Merged

Testing To Do list: part 1 #7

merged 2 commits into from Jan 19, 2022

Conversation

selma-belhadj
Copy link
Collaborator

@selma-belhadj selma-belhadj commented Jan 19, 2022

What does this PR do?

This PR is raised to add testing for todo app

Description of the task to be completed

  • Use Jest framework for testing.
  • Create the testing functions for adding an item to the To-Do list.
  • Create the testing functions for deleting an item in the To-Do list.
  • Create mock locale storage.

How should it be tested

Clone the repository

git clone https://github.com/omarsalem7/Todo-list-webpack.git

Navigate to the folder

cd Todo-list-webpack

Checkout the branch

git checkout testing-milestone1

Thanks for reviewing my PR 😊

Copy link

@moise10r moise10r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approve 🍾 👍 🎊

Hi @Team ,

Congratulations! 🎉 Project Approved ✅

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:

To Highlight 🥇

  • All functions responsible for adding and deleting list items have been well tested keep rocking 🚀

Cheers and Happy coding!👏👏👏💻

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@omarsalem7 omarsalem7 merged commit 439e0e4 into main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants