Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing To Do list: part 2 #8

Merged
merged 3 commits into from Jan 20, 2022
Merged

Testing To Do list: part 2 #8

merged 3 commits into from Jan 20, 2022

Conversation

selma-belhadj
Copy link
Collaborator

@selma-belhadj selma-belhadj commented Jan 19, 2022

What does this PR do?

This PR is raised to add testing part 2

Description of the task to be completed

  • Create a testing function for editing the task description.
  • Create a testing function for updating an item's 'completed' status.
  • Create a testing function for the "Clear all completed" function.
  • Use the mock storage object to mock the localStorage updates.

How should it be tested

Clone the repository

git clone https://github.com/omarsalem7/Todo-list-webpack.git

Navigate to the folder

cd Todo-list-webpack

Checkout the branch

git checkout testing-milestone02

Thanks for reviewing my PR 😊

Copy link

@moise10r moise10r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approve 🍾 👍 🎊

Hi @Team ,

Congratulations! 🎉 Project Approved ✅

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:

To Highlight 🥇

  • Your Pull Request has a proper title and description. ✔️
  • No Linter errors ✔️
  • Your testing has been well implemented, keep rocking 🚀

Cheers and Happy coding!👏👏👏💻

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@omarsalem7 omarsalem7 merged commit 2d053e6 into main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants