Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creates invalid code on AppVeyor/Windows #12

Closed
whilei opened this issue Sep 15, 2017 · 5 comments
Closed

creates invalid code on AppVeyor/Windows #12

whilei opened this issue Sep 15, 2017 · 5 comments

Comments

@whilei
Copy link

whilei commented Sep 15, 2017

go get github.com/omeid/go-resources/cmd/resources
resources -declare -var=DEFAULTS -package=assets -output=core/assets/assets.go core/config/*.json
2017/09/13 13:41:50 Finished in 261.0261ms. Wrote 2 resources to core/assets/assets.go
go test ./...
# github.com/ethereumproject/go-ethereum/core/assets
core\assets\assets.go:140:11: unknown escape sequence
core\assets\assets.go:92927:6: duplicate key "" in map literal
core\assets\assets.go:92927:13: unknown escape sequence

See https://github.com/whilei/go-resources/commits/appveyable + https://ci.appveyor.com/project/whilei/go-resources for simple reproducible test.

@omeid
Copy link
Owner

omeid commented Sep 17, 2017

Thanks for opening this issue. I don't use windows so sit has slipped through. I will look into it.

@omeid
Copy link
Owner

omeid commented Sep 21, 2017

Finally got a windows vm, I will fix this by end of the weekend. :)

@whilei
Copy link
Author

whilei commented Sep 21, 2017

Fantastic! I've been experimenting with a couple possible fixes myself, but haven't got a solve yet.

@whilei
Copy link
Author

whilei commented Oct 24, 2017

Any progress on this one @omeid?

@omeid omeid closed this as completed in ca9993b Oct 25, 2017
@omeid
Copy link
Owner

omeid commented Oct 25, 2017

Sorry it took a while, I had to setup a Windows Dev env for me to figure out what was going on.
If the pushed fix doesn't work for you. Please reopen the issue or create a new one. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants