Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for hue bar vertical positioning? #112

Closed
marko-hologram opened this issue Feb 22, 2021 · 2 comments
Closed

Support for hue bar vertical positioning? #112

marko-hologram opened this issue Feb 22, 2021 · 2 comments

Comments

@marko-hologram
Copy link

Greetings! First of all I just wanna say thanks for creating this cool tiny library. This is exactly what's needed on the project I'm working on currently.

I only have one "issue". Designs for the color picker in the app I'm working on were designed without using any library as reference and in the design the hue bar is vertical, but react-colorful has it by default in horizontal position.

I'm wondering if it's possible to achieve this layout? This is react-colorful btw, just with some different CSS.
image

Currently, no matter what I do and what positioning technique I use, the hue pointer can only slide left-right (you can see it actually overflows outside the hue bar).

Is this possible to achieve with the current library or is it something that would need to be integrated? Would you be willing to accept a PR to allow for something like this or you think it is unnecessary and would add bloat or unnecessary options?

I'm just trying to look at my options before reaching for another library or trying to convince designers to use the horizontal hue layout 😄

@omgovich
Copy link
Owner

Hi @marko-hologram! Thanks for the kind words!

I've thought about vertical sliders, but still not sure that it worth adding since it will make the package's bundle size 25-40% bigger. This factor is important for the maintainers of this repo because react-colorful is a micro-library and its goal is to be as small as possible.

Most of the popular in-app color pickers (Figma, Sketch, Chrome, etc) have horizontal hue and alpha sliders. The only vertical picker I know is Photoshop, but it doesn't feel like a good example to follow.

@marko-hologram
Copy link
Author

Hi @marko-hologram! Thanks for the kind words!

I've thought about vertical sliders, but still not sure that it worth adding since it will make the package's bundle size 25-40% bigger. This factor is important for the maintainers of this repo because react-colorful is a micro-library and its goal is to be as small as possible.

Most of the popular in-app color pickers (Figma, Sketch, Chrome, etc) have horizontal hue and alpha sliders. The only vertical picker I know is Photoshop, but it doesn't feel like a good example to follow.

Yep, totally understand you. I was mostly wondering if I was missing something while trying to make this work. Good news is that I just got an answer from designers and I won't be needing vertical sliders after all, we'll use the defaults that this library gives us.

Thanks for the response, I'll close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants