Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Implement "login keys" feature. #12

Closed
titanomachy opened this issue Jan 5, 2016 · 7 comments
Closed

Implement "login keys" feature. #12

titanomachy opened this issue Jan 5, 2016 · 7 comments

Comments

@titanomachy
Copy link

The "Login keys" feature is not implemented.

DirectAdmin has a "login key" feature to get access to a user's account, but restrict access to some specified functionality. The feature is described here.

@titanomachy titanomachy changed the title Implementing login keys Implement "login keys" feature. Jan 5, 2016
@curry684
Copy link
Member

curry684 commented Feb 1, 2016

I've done some practical testing with this over the weekend, and I'm curious: what does the library need to change even? Afaics it works fine to log in as a user with a login key, and all functions (if permitted) are available.

@barryvdh
Copy link
Contributor

barryvdh commented Feb 1, 2016

He probably wants the functionality to create/modify login keys using the API (CMD_API_LOGIN_KEYS)

@curry684
Copy link
Member

curry684 commented Feb 2, 2016

We had a mail discussion before this issue was posted, and it was about authentication :) Just don't think he realized it was functionally identical to a regular user login. Didn't test it though.

@titanomachy
Copy link
Author

Yes he is correct. I read the documentation, but could not find anything about the login keys. Did not think of DA not making a distinction between the two. I'll test it this weekend.

@curry684
Copy link
Member

curry684 commented Feb 2, 2016

Alright, reopen it if it doesn't :)

@titanomachy
Copy link
Author

Works fine. Some feedback about which CMD_API_* to enable when calling a method would be nice. Maybe the documentation is the best place for that. Source code shows it too of course. Probably should not be high on the list of features.

@curry684
Copy link
Member

curry684 commented Feb 7, 2016

The DA API is pretty much broken on that end. Even I spent like an hour getting a login key to actually work with limited access hehe.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants