Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This library needs more love #54

Closed
dlzi opened this issue Mar 20, 2017 · 11 comments
Closed

This library needs more love #54

dlzi opened this issue Mar 20, 2017 · 11 comments

Comments

@dlzi
Copy link

dlzi commented Mar 20, 2017

Sorry if I'm wrong, but this library seems quite behind the other ones. It's not updated as often as it could, and the lack of a good implementation tutorial makes it hard to figure out how it works. It would be great if Omise could give more attention to it.

@dlzi dlzi changed the title This library needs more ❤️ This library needs more love Mar 20, 2017
@guzzilar
Copy link
Contributor

Hi @danielzilli

Thank you for sharing your thought here.
And you're right, this library haven't updated for a while.

Anyway, feel free to share your idea further or submit your changes through the pull request to enhance the library. We're willing to hear our user thoughts more! 😃

Appreciate it. 👍
Nam

@dlzi
Copy link
Author

dlzi commented Mar 20, 2017

Hi @guzzilar

Thanks for the feedback.

I see that there are a few pull requests that are on hold. I think once they are merged, that would be nice enhancement to the library.

For my particular case, I would appreciate more tutorials or guides. Something like http://www.ilovephp.net/php/stripe-payment-gateway-integration-in-php-with-demo-examples/. That would help people that like me that is integrating Omise with a custom PHP CMS.

Cheers,
Daniel

@turboza
Copy link
Contributor

turboza commented Mar 20, 2017

Hi @danielzilli 😄

In case you are looking for tutorial for getting started, you can take a look here. https://www.omise.co/step-by-step-guide. This article includes basic usage of Omise, card.js and Omise-PHP.

@dlzi
Copy link
Author

dlzi commented Mar 20, 2017

Thank you @turboza, I know that link. :-)

However, I'm still wondering what is the "right" way to use card.js? I'm asking because https://www.omise.co/card-js-api and https://www.omise.co/step-by-step-guide are not exactly the same, when comes to how to use card.js.

Plus, at the step by step tutorial you say "Download card.js from github.com/omise/card.js (btw this link is broken). Unzip it and create an index.html file in the same folder."

That instruction is not clear to me, because next you created a form using the omise.js script, while card.js doesn't not appear anywhere.

PS: what are the main differences in building my own form and using card.js?

@turboza
Copy link
Contributor

turboza commented Mar 20, 2017

@danielzilli Thanks for the feedbacks 👍 I have just updated the step-by-step article to remove usage of Card.js since the Omise.js is going to replace to usage of Card.js. So you can just embed the script url https://cdn.omise.co/omise.js to use the form. I believe you can use https://www.omise.co/step-by-step-guide as a reference for implementation.

Let me know if you have a question.

@dlzi
Copy link
Author

dlzi commented Mar 20, 2017

Thank you. It's clearer now 👍

@dlzi
Copy link
Author

dlzi commented Mar 20, 2017

One last thing. I got the form working using the step by step guide. However, is there any guide if I want to implement my own form?

@turboza
Copy link
Contributor

turboza commented Mar 20, 2017

Sure, you can take a look in this document 😄
https://www.omise.co/collecting-card-information

@dlzi
Copy link
Author

dlzi commented Mar 20, 2017

👍

@guzzilar
Copy link
Contributor

Hi & thanks guys @danielzilli @turboza 😄 👍

By the way, @danielzilli thanks again for your feedback.
Are you ok if Im going to close this ticket (If no question further here)?

Cheers!
Nam

@dlzi
Copy link
Author

dlzi commented Mar 21, 2017

All good here. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants