Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different multipliers to calculate gas limit for different methods #127

Open
akolotov opened this issue Dec 26, 2018 · 0 comments
Open

Different multipliers to calculate gas limit for different methods #127

akolotov opened this issue Dec 26, 2018 · 0 comments

Comments

@akolotov
Copy link
Collaborator

akolotov commented Dec 26, 2018

The analysis of #126 exposes that calls of different methods requires different gas amount to be added extra to the amount provided by gasEstimate: e.g. the consumption of the executeAffirmation call could differ depending on the request sequence in three times, where as the call of executeSignatures consumes always the same (almost) amount of gas.

So, we need to provide different multipliers instead of one EXTRA_GAS_PERCENTAGE. For example,

EXECUTE_AFFIRMATION_EXTRA_GAS_PERCENTAGE
SUMBIT_SIGNATURE_EXTRA_GAS_PERCENTAGE
EXECUTE_SIGNATURE_EXTRA_GAS_PERCENTAGE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant