Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicated checks of contracts in ERC677BridgeTokenRewardable #217

Closed
akolotov opened this issue Jun 28, 2019 · 1 comment
Closed

duplicated checks of contracts in ERC677BridgeTokenRewardable #217

akolotov opened this issue Jun 28, 2019 · 1 comment
Assignees
@patitonar
Projects
Security audit for v2.3.2

Comments

@akolotov
Copy link
Collaborator

The method isContract is enough to check if operations are going to be made with an actual contract in the following methods:

https://github.com/poanetwork/poa-bridge-contracts/blob/e32ef6e1f2cc78a07fd96a321b426a64a2f87132/contracts/ERC677BridgeTokenRewardable.sol#L17-L25

The check ... != address(0) is redundant here.
@akolotov akolotov added this to Needs triage in Security audit for v2.3.2 via automation Jun 28, 2019
@akolotov akolotov moved this from Needs triage to Low priority in Security audit for v2.3.2 Jun 28, 2019
@patitonar patitonar self-assigned this Jul 3, 2019
@patitonar patitonar mentioned this issue Jul 3, 2019
Merged
@akolotov akolotov moved this from Low priority to Addressed in Security audit for v2.3.2 Jul 3, 2019
@akolotov
Copy link
Collaborator Author

Included in TokenBridge contracts 2.3.3

Security audit for v2.3.2 automation moved this from Addressed to Closed Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patitonar patitonar

Labels
None yet
Projects
No open projects
Security audit for v2.3.2
  
Closed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patitonar @akolotov