Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include a test with transferring 0 tokens the oracle e2e testing #58

Open
akolotov opened this issue May 22, 2019 · 0 comments
Open

include a test with transferring 0 tokens the oracle e2e testing #58

akolotov opened this issue May 22, 2019 · 0 comments
Labels
e2e related to end to end testing enhancement New feature or request oracle related to TokenBridge oracle

Comments

@akolotov
Copy link
Collaborator

There is a special scenario found on xDai bridge and addressed in https://github.com/poanetwork/poa-bridge-contracts/pull/165/files when 0 tokens are sent from the Foreign to the Home side.

Consider to extend the oracle e2e testing with the corresponding tests to make sure that this and similar issues could be found in the future.
@akolotov akolotov added oracle related to TokenBridge oracle e2e related to end to end testing enhancement New feature or request labels May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
e2e related to end to end testing enhancement New feature or request oracle related to TokenBridge oracle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akolotov