Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw dots on top of barres #48

Closed
Aduffy opened this issue Nov 30, 2020 · 6 comments
Closed

Draw dots on top of barres #48

Aduffy opened this issue Nov 30, 2020 · 6 comments
Labels

Comments

@Aduffy
Copy link

Aduffy commented Nov 30, 2020

If a finger dot and a barre are both defined on the same place, than the dot is UNDER the barre. The dot should be rendered on top of the barre..

I know in most cases one would not need to see that since the barre is repeating same note to hold down but in my case I am trying to show the chord notes with the interval or the note name

image

If you look close you can see the yellow (R) note peeking out under the top of the bar.

@omnibrain
Copy link
Owner

So do I understand correctly that all you want is to render single fingers on top of the barres?

@omnibrain
Copy link
Owner

OK I made this change as you are probably the only person affected by this. So even if I missunderstood there's no harm done :)

@Aduffy
Copy link
Author

Aduffy commented Dec 10, 2020

Thanks! It does come in handy in my case where I want to draw ALL of the notes played with the interval name (and color).

I did manage to hack my UMD build to get what i was looking for as well as adding a stroke to the notes so i could end up with this

image

I woudl have done a proper pull request with my my modifications but am not experienced wit github well enough to be sure I woudln't mess something up!

@omnibrain
Copy link
Owner

Looks good! But now you could also use the official library without hack. Whatever you prefer :)

I also just pushed a version where you can set the stroke width and color for both nuts and barre chords, should be released in 1-2 hours as soon as the build completes.

@Aduffy
Copy link
Author

Aduffy commented Dec 10, 2020

Ya I would much prefer to keep to a non hacked build! Thank you so much for implementing these changes for me!

@omnibrain
Copy link
Owner

🎉 This issue has been resolved in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants