4.x: @PreDestroy failing on MyFaces 4.x
#729
Comments
|
Here is a runnable reproducer: Just run Press the "Rebuild View" button. Mojarra 4.0 using `mvn clean jetty:run -Pmojarra40" MyFaces4.0 using `mvn clean jetty:run -Pmyfaces40" |
|
Weird with just Jetty I can't reproduce the exact issue I am getting in Quarkus |
|
OK I reported the MyFaces issue and fixed it and now the behavior matches in Mojarra and MyFaces: apache/myfaces#471 Now I need to figure out the Quarkus Error |
|
Ahh my reproducer above once I have fixed the NPE in MyFaces now produces a similar exception to Quakrus. |
|
I have confirmed the old SPI for ViewScope is not there in MYfaces 4.0 |
|
Found the original issue: https://stackoverflow.com/a/40552152/502366 And Discussion I think this |
|
Hmm ok, I wanted to reactivate MyFaces 4.x in the IT of OmniFaces but it still returns a lot of errors for 4.0.0-RC3. This already happened with RC1 and because there were so many errors and it was a beta version I didn't bother to look closer. Only thing which caught my eye that it uses .xml instead of .xhtml as default suffix: a64c049#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R84 This seems to be still the case according to ViewResourceHandlerIT. |
|
Let me look that would be a bad bug! |
|
Everywhere in the MyFaces 4.0 codebase I see it using .xhtml public static final String DEFAULT_FACELETS_SUFFIX = ".xhtml";
@Deprecated(since = "4.0")
public static final String DEFAULT_SUFFIX = ".xhtml"; |
|
Is it possible that somehow EXTENSIONLESS_MAPPING is enabled because locally my PrimeFaces test project with Myfaces 4.0 is respecting |
|
And in ProjectStage == DEVELOPMENT I see it print out this.. |
|
Locally tested and confirmed fixed with ece072b As to the wrong extension it appears to be specific to the ViewResourceHandlerIT itself. It looked ok in others. But still that strange |
|
Interesting. Thanks for fixing the original issue! It might be a bug with the MyFaces AJAX handling? |
|
Coming back to failing tests, majority of the ones failing with |
|
Thank you! I will push for an RC4 release this week because I would also like to continue testing Quarkus EE10 issues before final release. |
|
Still no clue about these RequestGuard errors every time when any form is ajax-submitted for the second time during the same view. Upgrading Selenium to 1.7.0 didn't help. Upgrading Graphene to 3.0.0 didn't help. Changing browser from htmlunit to phantomjs/firefox/chrome didn't help. Curious how MyFaces own unit tests deal with this use case. |
|
The Myfaces Integration tests just upgraded to Arquillian drone to 3.0.0-alpha.7 apache/myfaces#485 I know @bohmber did a lot to get them back working again. Our PrimeFaces Jakarta Integration Test suite is also passing with MyFaces 4.0 https://github.com/primefaces/primefaces/tree/master/primefaces-integration-tests-jakarta but it just uses straight Selenium 4.X |
|
@BalusC Myfaces 4.0.0-RC4 is in Maven Central if you want to update and try your integration tests again? |
|
Yup that fixed all tests failing with |
|
OK is there anything i can look into for that FullAjaxExceptionHandler I would like to get it fixed for RC5 ? |
|
Not sure. It's probably HtmlUnit related. This is the underlying error during that test and then the test fails because it couldn't find element by id This IT passes when PhantomJS is used but that in turn fails in a bunch of other tests. |
|
got it is there a way I can run this test myself? |
|
|
I tried but it fails with a fatal exception? Maven and JDK info: |
|
Arquillian Tomcat Plugin does in its current version not support Java 17. I'm using Java 11. |
|
Ahhh got it thanks. |
|
@werpu this sounds familiar like something you ran into with MyFaces TCK tests as well which is why you switched them to Selenium tests? |
|
Hi yes very familiar, we switched some of the TCK tests (the ajax ones) to a Selenium/chromium based implementation, because of HTMLUnit. |
|
Btw forgot: You can use https://github.com/werpu/tckworkbench as base... the utils folder is basically my framework on top of selenium and chrome... the utils folder is ASL2 but not the rest, so feel free to rip that part out and uses it wherever you like! (bugfixes are always welcome) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using
@PreDestroyfailing on MyFaces 4.x with OmniFaces 4.0.1.Code:
Error:
It looks like MyFaces 4.X has changed they way it handles ViewScope so this "hack" might not be needed anymore.
cc @tandraschko
The text was updated successfully, but these errors were encountered: