Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backporting of features to C API / Consolidating go-mapnik packages #1

Open
fawick opened this issue Jul 10, 2015 · 2 comments
Open

Comments

@fawick
Copy link

fawick commented Jul 10, 2015

Hi @olt, I just noticed your package and I really like the features you have added.

This is not really an issue with omniscale/go-mapnik, but have you considered offering your modifications to @springmeyer 's mapnik-c-api back upstream? I believe that the C-API really would benefit from the things you haved added, as would all derivative works.

@springmeyer
Copy link

I just added both of you as collaborators at https://github.com/springmeyer/mapnik-c-api. Would be great if you could create pull requests for any changes you see that would be improvements. I'll review and you can merge :)

@olt
Copy link
Member

olt commented Jul 13, 2015

We needed a Mapnik integration in Go with a few more options (layer selection, render options etc.) and both the C-API and your go-mapnik lacked important features for that. So, the easiest way was to just implement the API in a single repo and change what we need.

The current API is now stable and we use it in production. I'd love to merge features back.

I'm not sure how useful the layer selection feature would be, because it won't work as expected with Mapnik 3, since deactivated layers are not available from the Mapnik API anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants