Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipolygon strictness #40

Closed
bdon opened this issue Oct 15, 2014 · 3 comments
Closed

Multipolygon strictness #40

bdon opened this issue Oct 15, 2014 · 3 comments

Comments

@bdon
Copy link
Contributor

bdon commented Oct 15, 2014

Currently it seems imposm3 will ignore multipolygons that don't meet the current spec:
http://wiki.openstreetmap.org/wiki/Multipolygon_Examples

It looks like other import tools attempt to fix invalid multipolygons, of which there are many, into a usable state (see http://wiki.openstreetmap.org/wiki/Osmium/Multipolygon)

In my experience there can be some funkiness with missing riverbanks after imposm3 imports. I was wondering if the imposm3 authors and other users are interested in more forgiving multipolygon support (with the tradeoff being, a messier implementation).

@olt
Copy link
Member

olt commented Oct 16, 2014

Do you have any examples?

Imposm should handle almost all multipolygons. It supports whats is listed in the Osmium wikipage (self-intersection, wrong/missing inner/outer roles, etc.). The only thing that it doesn't support and that I'm aware of are unclosed polygons.

@bdon
Copy link
Contributor Author

bdon commented Oct 18, 2014

OK. I'll have to keep better track of how exactly the multipolygons i'm seeing missing are malformed. Will reopen issue when I come across one. Thanks, i wasn't aware that all the osmium cases were already covered.

@bdon bdon closed this as completed Oct 18, 2014
@olt
Copy link
Member

olt commented Oct 22, 2014

Polygons are now merged if there is a single gap and if the gap is not larger than ~0.1m. This should fix a few more invalid polygon cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants