[FE-7750] Fix inconsistent display of mapbox logo / watermark #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaitW
changed the title
CaitW
changed the title
CaitW
changed the title
jonvuri
reviewed
Feb 12, 2019
src/mixins/map-mixin.js
Outdated
| @@ -277,8 +277,9 @@ export default function mapMixin( | |||
| mapboxlogo.target = "_blank" | |||
| mapboxlogo.innerHTML = "Mapbox" | |||
|
|
|||
| const existingLogo = document.getElementsByClassName('mapbox-maplogo') | |||
| if(existingLogo.length ) { | |||
| const thisMapContainer = _map._container | |||
There was a problem hiding this comment.
How certain are we _map will never still be null here?
There was a problem hiding this comment.
Added check for null _map
src/mixins/map-mixin.js
Outdated
| const existingLogo = document.getElementsByClassName('mapbox-maplogo') | ||
| if(existingLogo.length ) { | ||
| const thisMapContainer = _map._container | ||
| const existingLogo = thisMapContainer.querySelectorAll('.mapbox-maplogo') |
There was a problem hiding this comment.
Seems like we could easily just use querySelector instead here, but unlikely to matter
There was a problem hiding this comment.
Changed because querySelector is better style
jonvuri
approved these changes
Feb 12, 2019
CaitW
deleted the
caitlin/FE-7750_inconsistent-display-of-mapbox-logo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
馃敡 Issue(s) fixed:
馃毈 Smoke Test
馃殺 Merge