Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Replace ERB with Haml everywhere #15

Closed
Mehonoshin opened this issue Oct 29, 2019 · 13 comments
Closed

Replace ERB with Haml everywhere #15

Mehonoshin opened this issue Oct 29, 2019 · 13 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Mehonoshin
Copy link
Member

Let's stick to a single template engine, and it would be haml

@Mehonoshin Mehonoshin added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 29, 2019
@romasks
Copy link
Contributor

romasks commented Nov 4, 2019

@Mehonoshin I'll take it.

@Mehonoshin
Copy link
Member Author

@romasks do it!

@romasks
Copy link
Contributor

romasks commented Nov 6, 2019

@Mehonoshin as I understand, you started doing this?

@Mehonoshin
Copy link
Member Author

@romasks no, I just assigned you to this issue

@romasks
Copy link
Contributor

romasks commented Nov 6, 2019

@Mehonoshin It's because of I see only haml files in apps/web/template

@romasks
Copy link
Contributor

romasks commented Nov 6, 2019

@Mehonoshin thanks, this is what I wanted to know.

And yes, you can assign me to #51

@romasks
Copy link
Contributor

romasks commented Nov 6, 2019

@Mehonoshin there is some problem with our sassc:

SassC::SyntaxError: Error: File to import not found or unreadable: config/fonts.
        on line 1 of stdin
>> @import "config/fonts";

The fix of this problem
So I propose to use the newest version of the gem - 2.2.1. But it can be only problem on my environment.

@Mehonoshin
Copy link
Member Author

Mehonoshin commented Nov 6, 2019

I haven't seen this error on my machine.
@artemrakov did you?

But anyway downgrading is not a way to go, try to fix it locally first.

@artemrakov
Copy link
Collaborator

No, I don't have this error.

@romasks
Copy link
Contributor

romasks commented Nov 6, 2019

Yes, downgrading is bad idea, but it was old solution.
Now I talk about upgrading sassc to newest version.
But first I'll check it on my linux machine (the problem occurs on my windows machine).

@romasks
Copy link
Contributor

romasks commented Nov 6, 2019

@Mehonoshin I've just create PR #56

@Mehonoshin
Copy link
Member Author

Solved, thanks @romasks !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants