New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better integration test #26

Open

axelocz opened this issue May 31, 2022 · 1 comment

Assignees

Labels

Contributor

axelocz commented May 31, 2022

test connection in email settings doesn't really do much of a test. i suggest the test actually tests the connection and authentication.

this could be easily done by using the parse email endpoint https://docs.omnivery.com/docs/mailgun-api-v3/517872689535a-parse-email-address

axelocz added the enhancement label

axelocz assigned mzagmajster

Collaborator

mzagmajster commented Jun 3, 2022

Right beside Test connection you have send test email button which I would guess at some point must authenticate to successfully send message.

While I have not checked if we can manipulate/override test connection button behavior.

Its a lot easier to create new button on Omnivery Settings tab (it exists now in configuration) and call this endpoint. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment