Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling is broken #4

Open
resignationinfinite opened this issue Nov 2, 2023 · 1 comment
Open

Error handling is broken #4

resignationinfinite opened this issue Nov 2, 2023 · 1 comment

Comments

@resignationinfinite
Copy link

resignationinfinite commented Nov 2, 2023

Upon running the tool, I get the following response:

> omnivore-import-demo@1.0.0 import
> npx babel-node -x .ts index.ts

Connecting to  https://api-prod.omnivore.app/api/graphql
error response: [object Object]
Successfully started import.

This is problematic both due to the unspecific error response, as well as the fact that the tool reports a successful import regardless of anything (the success message should presumably instead be included in the try block).

@tdhooten
Copy link

tdhooten commented Nov 2, 2023

I have created PR #5 to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants