Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipping a page with omnivore resulted in obsidian black screen on desktop and android app crashing #163

Open
c1505 opened this issue Nov 26, 2023 · 1 comment
Assignees

Comments

@c1505
Copy link

c1505 commented Nov 26, 2023

Obsidian should not crash based on the content in markdown file and I opened a bug for that side of things. https://forum.obsidian.md/t/obsidian-screen-goes-black-seconds-after-opening/71926/2 . I think this problem could also be prevented by the plugin.

Setup

  • page content enabled in sync
  • windows 11

What happened

  • Clipped this page with omnivore https://github.com/openai/evals/tree/main/evals/registry/evals
  • When omnivore synced, obsidian desktop turned to a black screen. Restarting, It would turn into a black screen in less than 5 seconds.
  • Troubleshooting other aspects did not fix obsidian
  • The resulting markdown file created was 12 MB. I think largely because it has the last commit message for every file on that page and each of these commit messages is large
  • deleting this file, fixed the problem

Possible changes that could prevent this problem from happening

  • An omnivore plugin setting that allows for a limitation of file size for import
  • Omnivore removes/sanitizes file content that would cause obsidian to crash

Additional details

  • I am not sure if it is the length size of the file or the file content that caused problems
  • The clipped file also would not render in vscode's markdown preview
@sywhb sywhb self-assigned this Dec 12, 2023
@sywhb
Copy link
Collaborator

sywhb commented Dec 12, 2023

Hey @c1505 , thanks for the detailed report!

Yeah I think if the file is too big, Obsidian will likely crush. Actually we do have a file size limit which is around 12MB but I guess it's still too big for Obsidian since it has to load it into memory.

I think to have a size limitation settings makes a lot of sense so we could reduce the file size and show some warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants