-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox Extension not saving articles due to permissions issue #3313
Comments
Thanks, yeah this consent is kind of an annoying requirement. It sounds like the extension might not have permission to write the API key and consent values to storage. When you refresh the settings is the API key also cleared? |
Appreciate the quick response! When I refreshed the page, the API key disappeared. However, I clicked 'Load API Key' and it now persists in the box upon refresh. The 'I consent' box still clears on refresh. |
Thanks. Are you familiar with using the Firefox developer console? If you could open the console, set the consent, then refresh the page maybe we will see something being blocked in the dev console |
I'm a firmware guy by trade but I can make do Checking the box, refreshing, doesn't yield anything different from the above console output. That gets printed as soon as the page loads but is unaffected by any of the actions on the page. If I understand this correctly, it looks like the JS file might not even be loading in correctly? |
Thanks, i think that gives me something to work with. Annoyingly adding this consent thing requires removing some of our content security policy. I will see if i can set up a replication of this. |
Hey, following up on this, were you able to recreate this? Otherwise, is there another way I can manually add articles from the browser to omnivore without using the extension? |
Yes, setting the api key and consent works but if these are essential, shouldn't the extension prompt for them on first run or when they are not set. It's both useless and frustrating to istall something only to have it not work. |
Hi guys. I stumbled on the same problem. Here are my observations:
But I think you should not use a key in the Firefox plugin. Obsidian plugins are different, API keys are commonplace there. Anyway, I'm not a plugin developer and I don't know what is technically or practically feasible. I just wanted to share my thoughts, given that I'm not aware of the implementation details. |
Normally you shouldn't need to set the API key manually, but I think your Firefox settings are preventing the extension from accessing the authentication cookie (maybe you have Firefox containers enabled?). I think we probably need a better way of detecting this for Firefox users as its becoming more common. |
You're right, I was trying to save a Facebook page when the error message was produced. And Facebook runs in its own container. Then I tried it on other pages. The issue didn't go away, though. It appeared on all pages I tried. Later I realized that the "I consent to data collection" checkbox was unchecked. Checking it seems to have resolved the issue. But I'm pretty sure I've allowed data collection yesterday (not sure where - it might have been during the registration). But still, these setting should not be hidden in the hamburger menu, I think. |
I have the same issue. Steps to reproduce:
![]() Expected behavior
|
I observed the following behavior on Firefox for Linux 106.0.1 (64-bit) using the Omnivore Extension Version 2.8.9
When attempting to save an article, I was prompted with a modal stating:
I've provided permission through both Firefox and the application. Additionally, I generated an API key via the Omnivore web application and saved it in the settings, but for obvious reasons, did not include a screenshot of it loaded here.
I figure one of two things could be occurring:
I'm happy to provide any more information as needed or if anything isn't clear. Thanks!
The text was updated successfully, but these errors were encountered: