New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Omn-382] - Updated landing page #393
Conversation
This pull request is being automatically deployed with Vercel (learn more). omnivore-demo – ./🔍 Inspect: https://vercel.com/omnivore/omnivore-demo/GGgDWDuuVaHAVToYALkmfwnsftTd omnivore-prod – ./🔍 Inspect: https://vercel.com/omnivore/omnivore-prod/GNk1vRJ2dJunVWMLFGC3uDKoTC4E |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there are some linting failures on this one. Can you test with yarn lint --fix
@jacksonh Apologies, This has been fixed. Thanks! |
One thing we need to be careful of on the landing page is to not use any theme colours, since a user could have the theme set to dark/light but this design doesn't have any theming. |
Four links to add here (don't have the Android one yet) |
Hi @jacksonh, We have removed the theme colors, added phosphor icons and links. The google play button has been commented out. |
Ah I figured out the colour issue I was seeing is because of light/dark theme. We have this css |
Sorry two last small things on this one:
|
@jacksonh This has been done as well, Thanks! |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Spec Checklist
Description
Based on Figma design here we have an updated landing page. This page should be built as /landing for now.
Figma designs:
-- Desktop: https://www.figma.com/file/ILgs6aXrPfukXOMf5Yibra/Omnivore---Deliverables?node-id=287%3A31514
-- Mobile: https://www.figma.com/file/ILgs6aXrPfukXOMf5Yibra/Omnivore---Deliverables?node-id=287%3A34213
Desktop:
Screen Shot 2022-04-04 at 22 21 38
Mobile:
Screen Shot 2022-04-04 at 22 21 51
Note how the design is divided into sections:
Simply reader-friendly
Make it your own
A better way to share
Discover new content
We will want to be able to enable/disable some of these sections, so they should be treated as separate pieces as we build.
#382
House Keeping
Ticket link (if applicable)
Task Link
How has this been tested?
Go to "localhost:3000/landing" page.
Types of changes
Checklist:
Loom Video
https://www.loom.com/share/5c3f51dc22174eff8e6b390c3600032e