Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Highlights section header below article just put the highlights directly under #868

Closed
jacksonh opened this issue Jun 23, 2022 · 4 comments
Assignees
Milestone

Comments

@jacksonh
Copy link
Contributor

No description provided.

@sywhb
Copy link
Contributor

sywhb commented Jun 27, 2022

Screenshot 2022-06-27 at 3 32 06 PM

@jacksonh we might not want to remove this header because there is an internal link to all the Highlights

@sywhb
Copy link
Contributor

sywhb commented Jun 27, 2022

Screenshot 2022-06-27 at 3 33 30 PM

@jacksonh
Copy link
Contributor Author

Hey @sywhb i tested it out and I think its OK to remove (I'll put up a PR). Unless I'm missing something, that internal page is pretty confusing. I think most users will probably want to get their highlights into this main Omnivore page and then pull the whole page block into another page.

@jacksonh
Copy link
Contributor Author

Added here: omnivore-app/logseq-omnivore#20

@jacksonh jacksonh self-assigned this Jun 28, 2022
@sywhb sywhb closed this as completed Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants