Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pi Range Disagreement #169

Closed
mamoll opened this issue Aug 20, 2013 · 1 comment
Closed

Pi Range Disagreement #169

mamoll opened this issue Aug 20, 2013 · 1 comment

Comments

@mamoll
Copy link
Member

mamoll commented Aug 20, 2013

Original report by Stephen Dunn (Bitbucket: entangledloops, GitHub: entangledloops).


The docs here use the eulerRPY function to generate a random value in the range [-pi, pi). However, an SO2State enforces bounds in the range of (-pi, pi]. You might want to consider adjusting one or the other to agree.

@mamoll
Copy link
Member Author

mamoll commented Sep 10, 2013

Original comment by Mark Moll (Bitbucket: mamoll, GitHub: mamoll).


Thanks. Strictly speaking, the eulerRPY doesn't return an array of SO2State objects, but it's probably best to be consistent with these bounds. Fixed in 1e46d79ba16d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant