Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListConfig iteration is much slower than plain list iteration #613

Closed
omry opened this issue Mar 17, 2021 · 0 comments · Fixed by #618
Closed

ListConfig iteration is much slower than plain list iteration #613

omry opened this issue Mar 17, 2021 · 0 comments · Fixed by #618
Labels
bug Something isn't working
Milestone
OmegaConf 2.1

Comments

@omry
Copy link
Owner

omry commented Mar 17, 2021 •
edited
Loading

See benchmark and discussion here.

Tentative for 2.1. Not sure where this is coming from.
@omry omry added the bug Something isn't working label Mar 17, 2021
@omry omry added this to the OmegaConf 2.1 milestone Mar 17, 2021
@omry omry changed the title ListConfig iteration is much slower than norma list iteration ListConfig iteration is much slower than plain list iteration Mar 17, 2021
@omry omry mentioned this issue Mar 18, 2021
Merged
@omry omry closed this as completed in #618 Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
OmegaConf 2.1
Development

Successfully merging a pull request may close this issue.

optimized list iterator some more omry/omegaconf
2 participants
@omry @Jasha10