Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated files use obsolete typing.io import #936

Open
4 tasks
srittau opened this issue May 18, 2022 · 0 comments
Open
4 tasks

Generated files use obsolete typing.io import #936

srittau opened this issue May 18, 2022 · 0 comments
Assignees
@pixelb
Labels
bug Something isn't working

Comments

@srittau
Copy link

srittau commented May 18, 2022

Describe the bug
Two generated files in omegaconf 2.2.1 use the typing.io namespace, which has been deprecated since Python 3.8 and will be removed in Python 3.12:

  • omegaconf/grammar/gen/OmegaConfGrammarLexer.py
  • omegaconf/grammar/gen/OmegaConfGrammarParser.py

This import can simply be replaced with an import from the main typing namespace as TextIO is available there.

Additional context

  • OmegaConf version: 2.2.1
  • Python version: any
  • Operating system: any
  • Please provide a minimal repro
@srittau srittau added the bug Something isn't working label May 18, 2022
@srittau srittau mentioned this issue May 18, 2022
Merged
@pixelb pixelb self-assigned this May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelb pixelb

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srittau @pixelb