Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add swipe delete on messages #54

Closed
wants to merge 4 commits into from
Closed

feat: add swipe delete on messages #54

wants to merge 4 commits into from

Conversation

isaacdarcilla
Copy link

This pull request resolve the delete button on messages #51 feature request. But instead of a delete button, I've used a swipe-to-delete method for a cleaner UI.

Sample screenshot.
Screenshot 2022-07-28 161834

Also, I've updated the UI for when there are no messages in the inbox.
Screenshot 2022-07-28 151620

All test has passed.
Screenshot 2022-07-28 162257

@vercel
Copy link

vercel bot commented Jul 28, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @joshxfi on Vercel.

@joshxfi first needs to authorize it.

@joshxfi
Copy link
Member

joshxfi commented Jul 28, 2022

Thanks for the pr! can we delete package-lock.json here and use yarn to install dependencies instead of npm? thanks!

@hyamero
Copy link
Member

hyamero commented Jul 28, 2022

There seems to be an issue with the swipe-to-delete method in desktop. The card opens when the mouse is released onMouseUp during the swipe action.

54-issue1.mp4

@hyamero hyamero marked this pull request as draft July 28, 2022 09:02
@isaacdarcilla
Copy link
Author

Thanks for the pr! can we delete package-lock.json here and use yarn to install dependencies instead of npm? thanks!

Yes, sure.

@isaacdarcilla
Copy link
Author

There seems to be an issue with the swipe-to-delete method in desktop. The card opens when the mouse is released onMouseUp during the swipe action.

54-issue1.mp4

I see. Let me check on it. Thanks!

@isaacdarcilla
Copy link
Author

Fixed the PR.

@hyamero
Copy link
Member

hyamero commented Jul 29, 2022

May I ask what the .idea folder and xml files are?

@isaacdarcilla
Copy link
Author

isaacdarcilla commented Jul 29, 2022

May I ask what the .idea folder and xml files are?

I forgot to add that folder in gitignore. That folder was generated by Webstorm IDE. Just like .vcs in Vscode

@hyamero
Copy link
Member

hyamero commented Jul 29, 2022

May I ask what the .idea folder and xml files are?

I forgot to add that folder in gitignore. That folder was generated by Webstorm IDE. Just like .vcs in Vscode

Can you remove those generated files and add it in .gitignore? Thanks!

@hyamero hyamero marked this pull request as ready for review July 29, 2022 11:19
@hyamero
Copy link
Member

hyamero commented Jul 29, 2022

also, would it be possible to:

  • return the card to the original position when the user clicks outside the box
  • return the previous card that have been "semi-swiped" to the original position when the user swipes a new card

As shown in the image, two cards are "semi-swiped", but it would be better if only one card is allowed, one at a time. Thanks!

image

@hyamero hyamero linked an issue Jul 29, 2022 that may be closed by this pull request
@isaacdarcilla
Copy link
Author

also, would it be possible to:

  • return the card to the original position when the user clicks outside the box
  • return the previous card that have been "semi-swiped" to the original position when the user swipes a new card

As shown in the image, two cards are "semi-swiped", but it would be better if only one card is allowed, one at a time. Thanks!

image

I think this behaviors are not supported by the package.

@hyamero
Copy link
Member

hyamero commented Aug 1, 2022

I see, can you please resolve your branch conflicts? Thanks!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete button on messages
3 participants