Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"request" runtime dependency unnecessary or undeclared #3

Closed
ob1 opened this issue Mar 19, 2014 · 1 comment
Closed

"request" runtime dependency unnecessary or undeclared #3

ob1 opened this issue Mar 19, 2014 · 1 comment

Comments

@ob1
Copy link
Contributor

ob1 commented Mar 19, 2014

The "request" module is declared as a dev dependency in "package.json", but is required at runtime by "ims-lti.coffee" though it seems to be unused there.

Thus, if my project doesn't explicitly require "request" on it's own, the ims-lti code breaks on requiring a nonexistent module.
@ob1 ob1 mentioned this issue Apr 2, 2014
Merged
@omsmith
Copy link
Owner

omsmith commented Apr 15, 2014

Closed by #8, thanks

@omsmith omsmith closed this as completed Apr 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ob1 @omsmith