Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration of Price on Request with calculatedPrice field #789

Open
4 tasks done
fredericalpers opened this issue Mar 28, 2024 · 4 comments · May be fixed by #793
Open
4 tasks done

Integration of Price on Request with calculatedPrice field #789

fredericalpers opened this issue Mar 28, 2024 · 4 comments · May be fixed by #793
Assignees
@dai-eastgate
Labels
component: property detail page Issue, Pull Request or Discussion related to property detail page component: property list Issue, Pull Request or Discussion related to property lists QA Issue or Pull request that is in review small change A change that is small that can be dealt with during ramp-up.
Milestone
v4.23

Comments

@fredericalpers
Copy link
Contributor

fredericalpers commented Mar 28, 2024 •
edited by dai-eastgate
Loading

Integration of Price on Request with calculatedPrice field

Introduction

calculatedPrice checks for the marketing type rent or purchase and then fills in the values of the field purchase price or rental price. This is particularly helpful for the output in the front end of the website, as you only have to add one field (calculatedPrice) and no longer have to add any dependencies for only displaying rental prices or only displaying purchase prices.

User Story

As a user of the onOffice for WP-Websites plugin, I sometimes rely on the Price on Request feature to not display prices on my website. I've encountered issues where the Price on Request feature functionality does not properly interact with the "calculatedPrice'' field. These inconsistencies in functionality detract from the overall user experience and may lead to confusion among users.

By ensuring compatibility with the Price on Request feature, users will benefit from consistent and accurate pricing information, enhancing their overall experience when working with calculated Prices.

Requirements / Tasks

  • Conduct an analysis of the current implementation of the "calculatedPrice" field and its interaction with the Price on Request feature.
  • Identify the missing configurations or integrations that prevent the Price on Request feature from working with the "calculatedPrice" field.
  • Develop a solution that the Price on Request feature is properly supported.
  • Conduct comprehensive testing to ensure that the changes resolve the issue and do not introduce any new issues.
@fredericalpers fredericalpers added small change A change that is small that can be dealt with during ramp-up. component: property list Issue, Pull Request or Discussion related to property lists component: property detail page Issue, Pull Request or Discussion related to property detail page component: unit list Issue, Pull Request or Discussion related to unit lists labels Mar 28, 2024
@fredericalpers fredericalpers added this to the v4.23 milestone Mar 28, 2024
@dai-eastgate
Copy link
Contributor

dai-eastgate commented Apr 2, 2024 •
edited
Loading

  • Conduct an analysis of the current implementation of the "calculatedPrice" field and its interaction with the Price on Request feature.
  1. @fredericalpers According to my investigate, "calculatedPrice" is displayed on the "price/surfaces" tab with the label "price". "calculatedPrice" works depends on the selected option of the "Type of commercialization" field in the "basic data" tab as follows:
  • Case "Rent": "calculatedPrice" is taken according to priority "basic rent -> Net cold rent -> Flat rent -> rent including heating
  • Case "lease": "calculatedPrice" is taken according to lease(pacht). If there is no lease value, "calculatedPrice" will be empty
  • Case "hereditary lease": "calculatedPrice" is obtained according to hereditary lease(erbpacht). If there is no lease value, "calculatedPrice" will be empty
  • Case "Purchase Price": "calculatedPrice" is obtained according to Purchase Price(kaufpreis). If there is no lease value, "calculatedPrice" will be empty
  1. And currently, the "Price on Request" feature is not affecting the "calculatedPrice" field.
    => Is this statement about "calculatedPrice" correct or not?
  • Identify the missing configurations or integrations that prevent the Price on Request feature from working with the "calculatedPrice" field.

The reason "calculatedPrice" field doesn't work properly is because the "calculatedPrice" field is not in the price fileds list

  • Develop a solution that the Price on Request feature is properly supported.

During implementation, I see you are setting the label as "component: unit list". However, I found that the unit list does not have the feature to "show price on request".
=> Is this a confusion between similar estates and unit list?
Please check and confirm whether my above statements are correct or not so I can continue implementing this issue. Thanks!

Note: The price on request feature will not work with adding the "price on request" field to the field list because there is a PR that ignores the "price on request" field: https://github.com/onOffice-Web-Org/oo-wp-plugin/pull/756/files

@fredericalpers fredericalpers removed the component: unit list Issue, Pull Request or Discussion related to unit lists label Apr 2, 2024
@fredericalpers
Copy link
Contributor Author

And currently, the "Price on Request" feature is not affecting the "calculatedPrice" field.
=> Is this statement about "calculatedPrice" correct or not?

correct, price on request is not affecting the "calculatedPrice" field, but it should be added to the field list.

During implementation, I see you are setting the label as "component: unit list". However, I found that the unit list does not have the feature to "show price on request".
=> Is this a confusion between similar estates and unit list?

this is indeed wrong. thank you! :)

@dai-eastgate dai-eastgate linked a pull request Apr 3, 2024 that will close this issue
Open
@dai-eastgate
Copy link
Contributor

dai-eastgate commented Apr 3, 2024 •
edited
Loading

@fredericalpers I have implemented it. This is video demo https://files.fm/u/3af2chf47d#/view/hb9v4n4ykw
Please check and let me know your opinion. Thanks!
Note: Unit test will work after merge PR #792

@fredericalpers
Copy link
Contributor Author

@fredericalpers I have implemented it. This is video demo https://files.fm/u/3af2chf47d#/view/hb9v4n4ykw Please check and let me know your opinion. Thanks! Note: Unit test will work after merge PR #792

@dai-eastgate looks good to me! thank you :) we will review this soon

@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Apr 8, 2024
@fredericalpers fredericalpers linked a pull request Apr 8, 2024 that will close this issue
46527 integration of price on request with calculatedprice field #793
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dai-eastgate dai-eastgate

Labels
component: property detail page Issue, Pull Request or Discussion related to property detail page component: property list Issue, Pull Request or Discussion related to property lists QA Issue or Pull request that is in review small change A change that is small that can be dealt with during ramp-up.
Projects
None yet
Milestone
v4.23
Development

Successfully merging a pull request may close this issue.

46527 integration of price on request with calculatedprice field onOffice-Web-Org/oo-wp-plugin
3 participants
@fredericalpers @yeneastgate @dai-eastgate