Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Email sending and creating data records issue with Honeypot Function on Property Detail Pages #857

Open
4 tasks done
fredericalpers opened this issue Jul 8, 2024 · 7 comments · May be fixed by #861
Open
4 tasks done
Assignees
Labels
bug Indicates an unexpected problem or unintended behaviour
Milestone

Comments

@fredericalpers
Copy link
Contributor

fredericalpers commented Jul 8, 2024

Fix Email sending and creating data records issue with Honeypot Function on Property Detail Pages

User Story

Based on customer feedback, there have been issues with incoming emails from property detail pages when the honeypot function is enabled. The form indicates successful submission, but no emails are received, and no address records are created. This issue appears to have started with version 4.18.

Task / Requirements

  • Analyze the code to identify what is causing the failure in email sending and creating data records when the honeypot function is active.
  • Ensure that when a form is submitted, the email is correctly sent to the specified address.
  • If applicable ensure that the address data record is properly created.
  • Ensure that the honeypot function works as intended, preventing spam without interfering with legitimate form submissions.
@fredericalpers fredericalpers added the bug Indicates an unexpected problem or unintended behaviour label Jul 8, 2024
@fredericalpers fredericalpers added this to the v4.26 milestone Jul 8, 2024
@yeneastgate yeneastgate self-assigned this Jul 10, 2024
@yeneastgate
Copy link
Contributor

@fredericalpers I have checked and currently the honeypot is not working on the detail page when using advanced custom fields. Is this the issue you are facing?

Please watch the bug video: https://files.fm/f/uj545er3ry

If so, please confirm so I can proceed with the implementation.

@fredericalpers
Copy link
Contributor Author

fredericalpers commented Jul 11, 2024

@yeneastgate It seems like this is the case. We will investigate further.

@yeneastgate
Copy link
Contributor

@yeneastgate It seems like this is the case. We will investigate further.

@fredericalpers Yes, I will wait for your response.

@fredericalpers
Copy link
Contributor Author

@yeneastgate unfortunately, this has not been confirmed. the error seems to persists even without acf.

however we would like to try your fix on a test website. Please create a Pull Request :)

@fredericalpers
Copy link
Contributor Author

fredericalpers commented Jul 12, 2024

@yeneastgate Our further tests have shown that:

  • The honeypot field is not added to the form. Therefore no e-mails are received.
  • The problem ONLY seems to exists if the units are to be displayed in the shortcode ([oo_estate units="Units list" view="detail"]).
  • It also does not seem to work if the shortcode with unit list is stored via the Gutenberg "Shortcode".

https://testinstanz-mr.onofficeweb.com/
Here the suggested fix also works for the unit list with the current detail page. As soon as a new detail page is created, the whole functionality with units no longer works. We suspect that the shortcode was stored somewhere outside ACFs/Gutenberg in the past, e.g. in the Classis Editor or in the database.

Related to Files are not loaded on property detail page unit Issue #799 ?

@fredericalpers
Copy link
Contributor Author

Info: Nach #799 nochmal testen, ob noch weitere Änderungen notwendig sind, oder ob 799 reicht.

fredericalpers pushed a commit that referenced this issue Jul 26, 2024
+ Fix Honeypot Bug as mentioned in #857
@fredericalpers
Copy link
Contributor Author

Should be fixed with the new release v5.0 and #800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behaviour
Projects
None yet
2 participants