Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a some error context to indicate when pop-launcher is missing #37

Closed
markstos opened this issue Dec 23, 2021 · 2 comments
Closed

Add a some error context to indicate when pop-launcher is missing #37

markstos opened this issue Dec 23, 2021 · 2 comments
Labels
good first issue Good for newcomers

Comments

@markstos
Copy link

Is your feature request related to a problem? Please describe.

Today I installed onagre for the first time and tried to start it but it immediately crashed:

onagre
Unable to load user theme: Unable to find theme settings file /home/mark/.config/onagre/theme.toml
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/subscriptions/pop_launcher.rs:87:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Describe the solution you'd like

I expected the tool to work with a no configuration file. Either some defaults should be used, or it should see that my config file is missing and copy a default config file into place and then start.

@oknozor
Copy link
Collaborator

oknozor commented Jan 16, 2022

Hello @markstos onagre does launch without a config file.
The thread panic occurs because you don't have pop-launcher installed on your system I think.

@markstos
Copy link
Author

Thanks. Perhaps it could fail more gracefully if pop launcher does not exist.

@oknozor oknozor changed the title Should start with no configuration file Add a some error context to indicate when pop-launcher is missing May 9, 2022
@oknozor oknozor added the good first issue Good for newcomers label May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants