Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add login component #161

Open
ciremusyoka opened this issue Jan 31, 2020 · 2 comments · Fixed by #162
Open

Add login component #161

ciremusyoka opened this issue Jan 31, 2020 · 2 comments · Fixed by #162
Assignees
@kelvin-muchiri @ciremusyoka
Labels
Standardization 🦄 core4client Work done to Gisida for Clients.

Comments

@ciremusyoka
Copy link
Contributor

ciremusyoka commented Jan 31, 2020 •
edited by kelvin-muchiri

  • Add Gatekeeper to Gisida
  • Move the Login component here to avoid adding it to all client projects.
    -Make Login component configurable
  • Make the login background image configurable from site-config pointing to the image path.
  • Make public credentials configurable from site config.
  • Make redirect url pick current host automatically.

The intention is to have use gatekeeper package and pull out our current implementation. We also want to move the Login component to gisida-react since we won't have to implement the same component on every other client which enforces dry. Having a single component that supports oauth, basic auth and no authentication in a configurable manner would be awesome
@ciremusyoka ciremusyoka self-assigned this Jan 31, 2020
@ciremusyoka ciremusyoka mentioned this issue Jan 31, 2020
Merged
@kelvin-muchiri kelvin-muchiri mentioned this issue Feb 3, 2020
Closed
1 task
@kelvin-muchiri
Copy link
Contributor

kelvin-muchiri commented Feb 5, 2020 •
edited

Also requires gate keeper integration. Currently on with @kahummer it.

onaio/gisida#358

@cKellyDesign
Copy link
Contributor

@kelvin-muchiri can this be closed now that #162 has been merged?

@cKellyDesign cKellyDesign added 🦄 core4client Work done to Gisida for Clients. Standardization labels Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kelvin-muchiri kelvin-muchiri

@ciremusyoka ciremusyoka

Labels
Standardization 🦄 core4client Work done to Gisida for Clients.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Login component onaio/gisida-react
3 participants
@cKellyDesign @kelvin-muchiri @ciremusyoka