Fi 497 - Check must support elements for fixed values

[ghost]

This PR was originally meant for slices marked as "must support". I've decided to go about this by checking for fixed values when checking must support elements and then removing duplicates. Before, when an element had a minimum cardinality of 0 and a fixed value, we never checked if the element found was the fixed value, and I'm guessing the profile validation wouldn't have picked it up because the minimum cardinality is 0.

Submitter:

• This pull request describes why these changes were made
• Internal ticket for this PR: https://oncprojectracking.healthit.gov/support/browse/FI-497
• Internal ticket links to this PR
• Internal ticket is properly labeled (Community/Program)
• Internal ticket has a justification for its Community/Program label
• Code diff has been reviewed for extraneous/missing code
• [] Tests are included and test edge cases
• Tests/code quality metrics have been run locally and pass

Reviewer 1:

Name:

• Code is maintainable and reusable, reuses existing code and infrastructure
  where appropriate, and accomplishes the task's purpose
• The tests appropriately test the new code, including edge cases
• You have tried to break the code

Reviewer 2:

Name:

• Code is maintainable and reusable, reuses existing code and infrastructure
  where appropriate, and accomplishes the task's purpose
• The tests appropriately test the new code, including edge cases
• You have tried to break the code

[arscan]

Have all comments been addressed?

[ghost]

Have all comments been addressed?

No, I'm trying to redo how the slice validation works.

[Jammjammjamm]

I encountered this in the smoking status sequence:

and this in the Practitioner sequence:

[ghost]

I encountered this in the smoking status sequence:

and this in the Practitioner sequence:

Should be fixed now.

[Jammjammjamm]

I still have the problem in the Practitoner sequence:

INFO | Inferno | Starting Test: USCPR-09 [All must support elements are provided in the Practitioner resources returned.]
ERROR | Inferno | Fatal Error: undefined method `values' for #<Array:0x00007fd81e630a08>
Did you mean?  values_at
ERROR | Inferno | [
  "inferno/lib/modules/uscore_v3.1.0/us_core_practitioner_sequence.rb:297:in `block (2 levels) in <class:USCore310PractitionerSequence>'",
  "inferno/lib/modules/uscore_v3.1.0/us_core_practitioner_sequence.rb:295:in `reject'",
  "inferno/lib/modules/uscore_v3.1.0/us_core_practitioner_sequence.rb:295:in `block in <class:USCore310PractitionerSequence>'",
  "inferno/lib/app/sequence_base.rb:427:in `instance_eval'",
  "inferno/lib/app/sequence_base.rb:427:in `run_test'"...]

[ghost]

I still have the problem in the Practitoner sequence:

INFO | Inferno | Starting Test: USCPR-09 [All must support elements are provided in the Practitioner resources returned.]
ERROR | Inferno | Fatal Error: undefined method `values' for #<Array:0x00007fd81e630a08>
Did you mean?  values_at
ERROR | Inferno | [
  "inferno/lib/modules/uscore_v3.1.0/us_core_practitioner_sequence.rb:297:in `block (2 levels) in <class:USCore310PractitionerSequence>'",
  "inferno/lib/modules/uscore_v3.1.0/us_core_practitioner_sequence.rb:295:in `reject'",
  "inferno/lib/modules/uscore_v3.1.0/us_core_practitioner_sequence.rb:295:in `block in <class:USCore310PractitionerSequence>'",
  "inferno/lib/app/sequence_base.rb:427:in `instance_eval'",
  "inferno/lib/app/sequence_base.rb:427:in `run_test'"...]

Woops, missed that part. Actually resolved now.

[arscan]

Ran against our reference data sets and the whole slice category of MUST SUPPORT issues are now gone. Good job!