Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Fi 600 build errors #418

Merged
merged 3 commits into from
Jan 24, 2020
Merged

Fi 600 build errors #418

merged 3 commits into from
Jan 24, 2020

Conversation

arscan
Copy link
Contributor

@arscan arscan commented Jan 20, 2020

Occasionally there are build errors on the practitioner role chain tests. One problem seems to be that inferno tests are trying to hit example.com/Practitioner... instead of example.com/fhir/Practitioner... and that could be because we haven't set a url on the testing instance.

Submitter:

  • This pull request describes why these changes were made
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Internal ticket is properly labeled (Community/Program)
  • Internal ticket has a justification for its Community/Program label
  • Code diff has been reviewed for extraneous/missing code
  • Tests are included and test edge cases
  • Tests/code quality metrics have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@arscan arscan changed the base branch from master to development January 20, 2020 20:17
@arscan
Copy link
Contributor Author

arscan commented Jan 20, 2020

No luck, still got the following:

** 1) Failure:
Inferno::Sequence::USCore310PractitionerroleSequence::PractitionerRole chained search by practitioner test#test_0007_fails if searching by practitioner.name does not return a Bundle [/home/travis/build/onc-healthit/inferno/lib/modules/uscore_v3.1.0/test/us_core_practitionerrole_test.rb:402]:
[Inferno::AssertionException] exception expected, not
Class: <WebMock::NetConnectNotAllowedError>
Message: <"Real HTTP connections are disabled. Unregistered request: GET http://www.example.com/Practitioner/practitioner1 with headers {'Accept'=>'application/json+fhir', 'Accept-Charset'=>'utf-8', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Authorization'=>'Bearer ACCESS_TOKEN', 'Host'=>'www.example.com', 'User-Agent'=>'Ruby FHIR Client'}\n\nYou can stub this request with the following snippet:\n\nstub_request(:get, \"http://www.example.com/Practitioner/practitioner1\").\n  with(\n    headers: {\n\t  'Accept'=>'application/json+fhir',\n\t  'Accept-Charset'=>'utf-8',\n\t  'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',\n\t  'Authorization'=>'Bearer ACCESS_TOKEN',\n\t  'Host'=>'www.example.com',\n\t  'User-Agent'=>'Ruby FHIR Client'\n    }).\n  to_return(status: 200, body: \"\", headers: {})\n\nregistered request stubs:\n\nstub_request(:get, \"http://www.example.com/fhir/PractitionerRole?practitioner.name=FAMILY_NAME\").\n  with(\n    headers: {\n\t  'Authorization'=>'Bearer ABC'\n    })\nstub_request(:get, \"http://www.example.com/fhir/Practitioner/practitioner1\").\n  with(\n    headers: {\n\t  'Authorization'=>'Bearer ABC'\n    })\n\n============================================================">
---Backtrace---
/home/travis/build/onc-healthit/inferno/vendor/bundle/ruby/2.5.0/gems/webmock-3.7.6/lib/webmock/http_lib_adapters/net_http.rb:114:in `request'
/home/travis/build/onc-healthit/inferno/vendor/bundle/ruby/2.5.0/gems/rest-client-2.1.0/lib/restclient/request.rb:473:in `net_http_do_request'
/home/travis/build/onc-healthit/inferno/vendor/bundle/ruby/2.5.0/gems/rest-client-2.1.0/lib/restclient/request.rb:733:in `block in transmit'
/home/travis/build/onc-healthit/inferno/vendor/bundle/ruby/2.5.0/gems/webmock-3.7.6/lib/webmock/http_lib_adapters/net_http.rb:123:in `start_without_connect'
/home/travis/build/onc-healthit/inferno/vendor/bundle/ruby/2.5.0/gems/webmock-3.7.6/lib/webmock/http_lib_adapters/net_http.rb:150:in `start'
/home/travis/build/onc-healthit/inferno/vendor/bundle/ruby/2.5.0/gems/rest-client-2.1.0/lib/restclient/request.rb:727:in `transmit'
/home/travis/build/onc-healthit/inferno/vendor/bundle/ruby/2.5.0/gems/rest-client-2.1.0/lib/restclient/request.rb:163:in `execute'
/home/travis/build/onc-healthit/inferno/vendor/bundle/ruby/2.5.0/gems/rest-client-2.1.0/lib/restclient/request.rb:63:in `execute'
/home/travis/build/onc-healthit/inferno/vendor/bundle/ruby/2.5.0/gems/rest-client-2.1.0/lib/restclient.rb:66:in `get'
/home/travis/build/onc-healthit/inferno/vendor/bundle/ruby/2.5.0/gems/fhir_client-4.0.3/lib/fhir_client/client.rb:465:in `get'
/home/travis/build/onc-healthit/inferno/lib/app/ext/fhir_client.rb:24:in `get'
/home/travis/build/onc-healthit/inferno/vendor/bundle/ruby/2.5.0/gems/fhir_client-4.0.3/lib/fhir_client/sections/crud.rb:11:in `read'
/home/travis/build/onc-healthit/inferno/vendor/bundle/ruby/2.5.0/gems/fhir_client-4.0.3/lib/fhir_client/ext/model.rb:69:in `read'
/home/travis/build/onc-healthit/inferno/vendor/bundle/ruby/2.5.0/gems/fhir_client-4.0.3/lib/fhir_client/ext/reference.rb:64:in `read'
/home/travis/build/onc-healthit/inferno/lib/modules/uscore_v3.1.0/us_core_practitionerrole_sequence.rb:167:in `block in <class:USCore310PractitionerroleSequence>'
/home/travis/build/onc-healthit/inferno/lib/app/sequence_base.rb:427:in `instance_eval'
/home/travis/build/onc-healthit/inferno/lib/app/sequence_base.rb:427:in `run_test'
/home/travis/build/onc-healthit/inferno/lib/modules/uscore_v3.1.0/test/us_core_practitionerrole_test.rb:402:in `block (4 levels) in <top (required)>'**

@arscan arscan merged commit 3bfb77e into development Jan 24, 2020
@radamson radamson mentioned this pull request Aug 9, 2020
@arscan arscan deleted the fi-600-build-errors branch September 10, 2020 04:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant