Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Fi 607 cache ref resolution #425

Merged
merged 6 commits into from
Jan 28, 2020
Merged

Conversation

arscan
Copy link
Contributor

@arscan arscan commented Jan 25, 2020

Fixes a few bugs in the US Core generator. Also caps resource resolution step to a max number of references to follow (currently set to 50), and won't resolve the same reference multiple times, because this was tying up our database and tests were taking way too long to run for little benefit.

Submitter:

  • This pull request describes why these changes were made
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Internal ticket is properly labeled (Community/Program)
  • Internal ticket has a justification for its Community/Program label
  • Code diff has been reviewed for extraneous/missing code
  • Tests are included and test edge cases
  • Tests/code quality metrics have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@arscan arscan force-pushed the fi-607-cache-ref-resolution branch from 8ffa97b to 5626579 Compare January 27, 2020 03:58
Copy link

@okeefm okeefm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the generator and the modules it generates; looks good to me.

@Jammjammjamm Jammjammjamm merged commit 938b2c5 into development Jan 28, 2020
@Jammjammjamm Jammjammjamm deleted the fi-607-cache-ref-resolution branch January 28, 2020 16:11
@radamson radamson mentioned this pull request Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants