Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Update UMLS Version #426

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Update UMLS Version #426

merged 1 commit into from
Jan 30, 2020

Conversation

radamson
Copy link
Contributor

@radamson radamson commented Jan 26, 2020

  • Updates the version of UMLS from 2018AB to 2019AB.
  • Create msgpack files with wb open mode to avoid encoding issues encountered during debugging.
  • Remove ValueSets that use NDF-RT which has been replaced by MED-RT
  • Fix issue where #import_valueset returned a Inferno::Terminology::Valueset instead of the expected Set

Submitter:

  • This pull request describes why these changes were made
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Internal ticket is properly labeled (Community/Program)
  • Internal ticket has a justification for its Community/Program label
  • Code diff has been reviewed for extraneous/missing code
  • Tests are included and test edge cases
  • Tests/code quality metrics have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@radamson radamson requested a review from arscan January 26, 2020 17:35
Copy link

@okeefm okeefm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@okeefm okeefm merged commit d7a4d6c into development Jan 30, 2020
@okeefm okeefm deleted the umls_update branch January 30, 2020 14:44
@radamson radamson mentioned this pull request Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants