Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

FI-584: Validate CapabilityStatement #436

Merged
merged 2 commits into from
Feb 6, 2020

Conversation

Jammjammjamm
Copy link
Contributor

This branch makes test C-02 validate the server's CapabilityStatement. Before, it just checked that a CapabilityStatement model could be populated from the server's response without actually validating the contents of the CapabilityStatement.

Submitter:

  • This pull request describes why these changes were made
  • Internal ticket for this PR: https://oncprojectracking.healthit.gov/support/browse/FI-584
  • Internal ticket links to this PR
  • Internal ticket is properly labeled (Community/Program)
  • Internal ticket has a justification for its Community/Program label
  • Code diff has been reviewed for extraneous/missing code
  • Tests are included and test edge cases
  • Tests/code quality metrics have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@Jammjammjamm Jammjammjamm self-assigned this Feb 6, 2020
@okeefm okeefm self-requested a review February 6, 2020 13:56
Copy link

@okeefm okeefm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with an external CapabilityStatement; worked for me.

@Jammjammjamm Jammjammjamm merged commit fd81271 into development Feb 6, 2020
@Jammjammjamm Jammjammjamm deleted the fi-584-validate-capability-statement branch February 6, 2020 19:26
@radamson radamson mentioned this pull request Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants