Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

FI-640: Improve performance of save_resource_references #443

Merged
merged 2 commits into from
Jul 31, 2020

Conversation

Jammjammjamm
Copy link
Contributor

This branch incorporates the performance improvements that were implemented in the program edition.

Submitter:

  • This pull request describes why these changes were made
  • Code diff has been reviewed for extraneous/missing code
  • n/a Tests are included and test edge cases
  • Tests/code quality metrics have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@Jammjammjamm Jammjammjamm self-assigned this Mar 20, 2020
Copy link
Contributor

@radamson radamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself looks good and matches what is expected based on the previously reviewed PR for Program.

It might be worth rebasing and regenerating here to make sure that the generated code is up to date.

@yunwwang
Copy link
Contributor

Code change looks good. There is a codeclimate/diff-coverage error.

Copy link
Contributor

@yunwwang yunwwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Unit tests passed

@radamson radamson merged commit b9c0ef1 into development Jul 31, 2020
@radamson radamson deleted the fi-640-improve-performance branch July 31, 2020 20:10
@radamson radamson mentioned this pull request Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants