Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Connectathon 24 #454

Merged
merged 3 commits into from
Jun 10, 2020
Merged

Connectathon 24 #454

merged 3 commits into from
Jun 10, 2020

Conversation

yunwwang
Copy link
Contributor

There are two changes to Inferno bulk data testing:
Sync tests with BDT service. Generated new Metadata test.
Fix failure when response body is nil

Submitter:

  • This pull request describes why these changes were made
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Internal ticket is properly labeled (Community/Program)
  • Internal ticket has a justification for its Community/Program label
  • Code diff has been reviewed for extraneous/missing code
  • Tests are included and test edge cases
  • Tests/code quality metrics have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@yunwwang yunwwang requested a review from arscan May 18, 2020 16:41
@yunwwang yunwwang merged commit 3289c38 into development Jun 10, 2020
@yunwwang yunwwang deleted the connectathon-24 branch June 10, 2020 18:18
@radamson radamson mentioned this pull request Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants