Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Fi 886 - Basic read/validate test generator #468

Merged
merged 8 commits into from
Jul 24, 2020
Merged

Fi 886 - Basic read/validate test generator #468

merged 8 commits into from
Jul 24, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 10, 2020

This PR adds a "generic" generator that creates basic read and validate tests based on the structure definitions in an IG.
To run, use bundle exec rake inferno:generate['generic','ig_folder'] where ig_folder is the name of the folder in the resource folder.

Submitter:

  • This pull request describes why these changes were made
  • Internal ticket for this PR: https://oncprojectracking.healthit.gov/support/browse/FI-886
  • Internal ticket links to this PR
  • Internal ticket is properly labeled (Community/Program)
  • Internal ticket has a justification for its Community/Program label
  • Code diff has been reviewed for extraneous/missing code
  • Tests are included and test edge cases
  • Tests/code quality metrics have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@okeefm okeefm requested a review from radamson July 21, 2020 17:22
end

def generate_module
file_name = "#{module_yml_out_path}/#{@path}_module.yml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful for me if this were its own method.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module_info part?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename, so that we can easily locate the generated module file elsewhere.

Copy link
Contributor

@radamson radamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@radamson radamson merged commit ff81cb2 into development Jul 24, 2020
@radamson radamson deleted the FI-886 branch July 24, 2020 15:44
@radamson radamson mentioned this pull request Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants