Pkg currently not working with node-rsa 0.2.20

[erikmunson]

A couple of days ago node-rsa released version 0.2.20. This update appears to have been minor, but after updating the deps for crx my builds started failing. A quick look at the stack trace revealed this (taken directly from console):

Error: TypeError: undefined is not a function
  at jenkins-home/workspace/SignalsExtension-Master/node_modules/crx/src/crx.js:83:13
  at $$$internal$$tryCatch (jenkins-home/workspace/SignalsExtension-Master/node_modules/crx/node_modules/es6-promise/dist/es6-promise.js:304:16)
  at $$$internal$$invokeCallback (jenkins-home/workspace/SignalsExtension-Master/node_modules/crx/node_modules/es6-promise/dist/es6-promise.js:316:17)
  at jenkins-home/workspace/SignalsExtension-Master/node_modules/crx/node_modules/es6-promise/dist/es6-promise.js:874:13
  at $$asap$$flush (jenkins-home/workspace/SignalsExtension-Master/node_modules/crx/node_modules/es6-promise/dist/es6-promise.js:111:9)
  at process._tickCallback (node.js:419:13)

Manually hard-coding the node-rsa dependency in package.json seems to totally resolve the issue. I will try to post more detailed logging shortly, but this happened on a Jenkins box so I don't have the full logs.

As a side note: I am loading a key.pem file into crx via a string buffer, then packing an extension.

[thom4parisot]

@erikmunson thanks for your report. You might double post it on the node-rsa issue tracker. If a method got deprecated/removed, its maintainer should have bumped the major version.

[erikmunson]

@oncletom Perfect, will do.

[erikmunson]

@oncletom Turns out this was a small bug in v0.2.20 that just got patched in v0.2.21. Tested on the build which had been failing and works great. Thanks for prompting to cross-post on node-rsa!

Details: rzcoder/node-rsa#32

[thom4parisot]

That's great :-) I love solving problems without writing a single line of code ;-)

[erikmunson]

Amen!