Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrench and temp and favour using archive.bulk method #59

Closed
4 tasks done
thom4parisot opened this issue Sep 21, 2016 · 0 comments · Fixed by #62
Closed
4 tasks done

Remove wrench and temp and favour using archive.bulk method #59

thom4parisot opened this issue Sep 21, 2016 · 0 comments · Fixed by #62
Milestone

Comments

@thom4parisot
Copy link
Owner

thom4parisot commented Sep 21, 2016

There are regular bugs (#57 #17) about temporary files not being deleted.

Plus I do not like the idea we generate temporary files during crx.load and copy them again into a zip archive.

Here is the proposed plan:

  • crx.load() should load only the manifest
  • a new method should:
    1. locate the files in the folder containing the manifest.json
    2. filter out the ones which do not comply to exclude rules and list them for audit/inspection purposes
    3. return a map of src/dest to include in the extension
  • pass the src/dest list to archiver.bulk during crx.pack()
  • archiver.glob contains all the necessary selection and exclusion logic

Many advantages:

  1. we reduce the number of dependencies
  2. we benefit of an exclude system which can back Set ignore file to .crxignore like .gitignore #49 and/or Implement .crxignore #51 and mostly src pattern DOES NOT ignore elements grunt-crx#44
  3. everything is achievable with archiver directly
  4. the user is in control of what is written on disk
@thom4parisot thom4parisot changed the title Replace wrench because it is deprecated Remove wrench and temp and favour using archive.bulk method Sep 21, 2016
@thom4parisot thom4parisot added this to the v3.1.0 milestone Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant