Add support for fully qualified domains (trailing dot in domain name) #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,16 +17,20 @@ var URL = require('url'); | |||
| var hasPrefixRE = /^(([a-z][a-z0-9+.-]*)?:)?\/\//; | |||
| var invalidHostnameChars = /[^A-Za-z0-9.-]/; | |||
|
|
|||
| function trim(value) { | |||
| return String(value).replace(/(^\s+|\s+$)/g, ''); | |||
| function ltrim(value) { | |||
There was a problem hiding this comment.
Thinking about it, we could also just use the plain old String.prototype.trim as it is supported since ECMAScript 5.0.
I'll make the change prior to publish the new release 👍
thom4parisot
approved these changes
Jul 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #95
I added a few tests, although I'm not sure they are all necessary since hostname cleaning happens before each of them. Although it still adds some value as documentation for valid use cases.
Also, during cleaning, I created two helpers:
URL.parsedoes it already).Let me know if it's good for you!
Rémi