Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a benchmark script to tld.js to measure performance evolution #98

Merged
merged 5 commits into from
Sep 3, 2017

Conversation

remusao
Copy link
Collaborator

@remusao remusao commented Sep 2, 2017

This PR adds a bin/benchmark script, measuring all functions part of the public API. I tried to design the set of URLs tested during the benchmark to be representative, and diverse enough to hit different corner cases (* rules, ICANN rules, Private rules, exceptions, unicode, etc.).

@thom4parisot thom4parisot merged commit e86f6fd into thom4parisot:master Sep 3, 2017
@remusao
Copy link
Collaborator Author

remusao commented Sep 4, 2017

@oncletom Thanks for merging.

I tried to run the command: npx tldjs -c './bin/benchmark.js', but I get: command not found: tldjs. Am I missing something?

@thom4parisot
Copy link
Owner

@remusao yeah, I think I made a mistake. When I tested the command before publishing I did:

npx -p . -c './bin/benchmark.js'

So I assumed npx <package> -c ... would run the command as of the npm context of this package. Which is not the case… Will raise that at a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants