Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve navbar on smaller screen sizes #3742

Closed
calvinlu3 opened this issue Jun 3, 2024 · 1 comment · Fixed by oncokb/oncokb-public#1127
Closed

Improve navbar on smaller screen sizes #3742

calvinlu3 opened this issue Jun 3, 2024 · 1 comment · Fixed by oncokb/oncokb-public#1127

Comments

@calvinlu3
Copy link
Contributor

Currently, the navbar items are left aligned, which introduces some extra spacing on the right when there is a line break. This causes the CDx nav item to appear shifted right.

Image

One option is to make the nav items center aligned:

Image

Another issue is that on a small screen, there is not enough margin to distinguish between adjacent nav items.

@calvinlu3
Copy link
Contributor Author

Temporary solution:
We will text-align: center and remove Account for < 13'' laptops.

In the future, we want to explore "Mega Menu" to group certain pages together. (example: https://www.webstacks.com/blog/design-menu-navigation-ux-strategy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants