force conversion to UTF-8

[michaelshobbs]

No description provided.

[zuazo]

OK. Thanks @michaelshobbs. Could you add some tests?

[michaelshobbs]

My ruby skills are shoddy at best. If you want to point me in the right direction, I'm willing to take a stab at it though.

As a side note, I confirmed that this works in my OpsWorks situation.

[zuazo]

OK. Don't worry.

Currently I'm not using SNS. Could you check whether SNS (mail?) messages are sent in UTF-8?

[michaelshobbs]

Looking at the headers I see this:

Content-Type: text/plain; charset=UTF-8

[michaelshobbs]

Thoughts on where to go from here?

[zuazo]

Sorry @michaelshobbs. I want to merge this PR. But I want to add some tests before. Give me a couple of days.

[michaelshobbs]

no worries. i appreciate you looking at it for sure.

[zuazo]

Hello @michaelshobbs,

I merged this in 712a5bc. Then I improved it in e36a38b, including some tests.

I just want to clarify that this fix works only for Ruby >= 2.1.0. Let me know if that is not enough.

[michaelshobbs]

Sounds good. I'll test it out ASAP

[michaelshobbs]

It looks like OpsWorks is using Ruby 2.0.0.
http://docs.aws.amazon.com/opsworks/latest/userguide/workingcookbook-ruby.html

root@host:/var/lib/aws/opsworks/chef# /opt/aws/opsworks/local/bin/ruby --version
ruby 2.0.0p645 (2015-04-13 revision 50299) [x86_64-linux]

Any way we can get support for that?

[zuazo]

@michaelshobbs, thanks for your fast feedback 😉

Fixed for Ruby >= 1.9.2 in 61e7b60.

[michaelshobbs]

Excellent! Is this in a release yet? If not I think I can just copy the new sns.rb into place over a chef-handler-sns-1.2.0 install, correct?

[zuazo]

It's not released yet. But yes, you can test it by copying the sns.rb file.

[zuazo]

Released in 2.0.0.