New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/attr apply #10
Conversation
Thanks @realloc for your PR. Could you fix the RuboCop offenses and add some tests (test-kitchen or ChefSpec)? |
Fixed rubocop. Added simple ChefSpec test. |
chain_encrpted chain_secret_file chain_content | ||
chain_combined_name chain_combined_path ca_cert_path ca_key_path | ||
).each do |attr| | ||
send(attr, item_hash[attr]) if item_hash[attr] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand this correctly, something like this should do the same:
node['ssl_certificate']['items'].each do |item_hash|
ssl_certificate item_hash[:name] do
namespace item_hash
end
end
Am I missing something?
Yes, your code does the same thing better. |
Released in 1.4.0. Thanks for your contribution! |
Adding recipe to define ssl_certificate resources from node attributes.